Pass OPTION_FORGIVING to VObject Reader
#902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Kaafarani <[email protected]>
This was referenced Apr 7, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
|
@kvikshaug please provide the patch upstream to sabreDav https://github.com/sabre-io/dav, we will pull then a new release |
4 tasks
|
This patch is very much needed. Has anyone opened an issue or merge request on sabreDav upstream ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the "forgiving" option, some ICS files that would otherwise be rejected, can be successfully imported.
Specifically, Outlook for Mac generates ICS files with an invalid key
X-ENTOURAGE_UUID(underscore is invalid). By being forgiving, this key is ignored instead of rejected and I think a majority of calendar invitations from that client can now be processed successfully for NextCloud users. See issues nextcloud/server#16679 and nextcloud/server#17915 for more context.I haven't seen other calls to
VObject\Reader::readorVObject\Reader::readJsonoutside ofvalidateICalendarwhere the same option should be passed, but it's possible I missed something.