-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump icewind/streams from 0.7.2 to 0.7.5 #730
Bump icewind/streams from 0.7.2 to 0.7.5 #730
Conversation
78bcac5
to
cd7b0f3
Compare
composer/platform_check.php
Outdated
@@ -8,6 +8,28 @@ | |||
$issues[] = 'Your Composer dependencies require a PHP version ">= 7.3.0". You are running ' . PHP_VERSION . '.'; | |||
} | |||
|
|||
$missingExtensions = array(); | |||
extension_loaded('ctype') || $missingExtensions[] = 'ctype'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are strange. do you also get them when you try to re-vendor deps on the base branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not get them on stable21
. Only the following files are touched.
modified: composer/ClassLoader.php
modified: composer/InstalledVersions.php
modified: composer/autoload_files.php
modified: composer/autoload_static.php
modified: composer/installed.json
modified: composer/installed.php
modified: composer/package-versions-deprecated/src/PackageVersions/Versions.php
@ChristophWurst @juliushaertl I've rerun composer update with composer composer 2.1.9 hopefully the diff is now cleaner |
damn, conflicts... |
@dependabot-bot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
c5bca48
to
4f52e30
Compare
what ? why are there no file changes ?? I'll do the update again locally and push |
e7d0280
to
4303b74
Compare
alright, now it looks good. Please review! |
4303b74
to
f1eae7f
Compare
why is it so difficult to update the lib ? this is what I did:
let's see... |
e3e81ef
to
917807d
Compare
Signed-off-by: Vincent Petry <[email protected]>
917807d
to
d12a875
Compare
finally green... I had to do exactly the same thing that CI is doing. I'll put that in the README in a separate PR |
Don't forget to update https://github.com/nextcloud/server/tree/stable21/apps/files_external/3rdparty |
Bumps icewind/streams from 0.7.2 to 0.7.5.
Release notes
Sourced from icewind/streams's releases.
Commits
0c6aae1
Merge pull request #15 from juliushaertl/enh/wrapsource-modec492db9
Add mode parameter to wrapSource93bce47
dont throw errors on double close in stream wrapper22ef9fc
7.1895940d
7.0?21897ce
try testing with older phpunit0181f87
fix tests for 7.36479281
test php versions1c6d181
fixup testsb8bea69
badgeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)