Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote error with pragma_foreign_key_list() causes errors and upgrade failures. #1767

Closed
wants to merge 1 commit into from

Conversation

kpneal
Copy link

@kpneal kpneal commented Apr 1, 2024

The pragma_foreign_key_list() function returns a table with the "seq" column being a number. Attempting to treat this column as anything else is an error and causes errors. Fix that error by removing quote marks.

Discussion: nextcloud/server#44445

column being a number. Attempting to treat this column as anything else
is an error and causes errors. Fix that error by removing quote marks.
@nbakker
Copy link

nbakker commented Apr 1, 2024

This accommodates a change of defaults in SQLite: https://www.sqlite.org/quirks.html#double_quoted_string_literals_are_accepted

@nbakker
Copy link

nbakker commented Apr 1, 2024

@joshtrichards
Copy link
Member

This PR needs to go upstream to the actual dependency; it's not our code:

That said, looks like doctrine/dbal#6325

@joshtrichards
Copy link
Member

Should get picked up from upstream in the next doctrine/dbal bump (to 3.8.4) when it's released. At the moment v3.8.4 (which has the fix) isn't yet released.

@nickvergessen
Copy link
Member

yeah, we are not patching things manually.

That being said, we plan to update to doctrine/dbal 4 in master soon.
But we can try to upgrade the dependency in the other versions that ship 3.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants