Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly use MySQL for phpunit-mysql and add phpunit-mariadb for MariaDB #237

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 21, 2023

The workflow name and description says MySQL but MariaDB was used.

Instead use MySQL but provide an optional MariaDB template.

@susnux susnux added the 3. to review Waiting for reviews label Oct 21, 2023
@susnux susnux force-pushed the fix/mysql-maria-db branch 2 times, most recently from da2b107 to e17a374 Compare October 21, 2023 20:49
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the fix and split. Discussed it with Julius when text had a bug that only happened on MySQL but not Maria in summer, but we didn't find the time to execute it

workflow-templates/phpunit-mariadb.yml Outdated Show resolved Hide resolved
@nickvergessen nickvergessen merged commit 4071554 into master Oct 22, 2023
3 checks passed
@nickvergessen nickvergessen deleted the fix/mysql-maria-db branch October 22, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants