-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 12.0 #280
Comments
Resolve nextcloud-snap#280. Signed-off-by: Kyle Fazzari <[email protected]>
Thanks @MariusBluem. Would you mind taking a look at #281 (there are testing instructions there)? Something is wrong here... at least in firefox, I'm getting this: I'm not sure where the MIME type mismatch is coming from, all I'm changing here is the Nextcloud version. Are there requirements of which I'm unaware? |
Currently blocked on nextcloud/server#5057. |
Any chance (technically) of catching these problems via CI and acceptance tests? |
Yes, although we'd need an environment in which we could run the snap (the travis kernel doesn't use the right config), as well as a test suite to run (e.g. I have some experience with capybara). Does Nextcloud have an acceptance suite? |
We use drone, so could use a docker which loads snaps. |
Yeah that would work well. Would it be possible to get access to your drone infrastructure? |
@MorrisJobke for Drone infrastructure |
@kyrofa I think it should be possible to use it, but I wouldn't expect anything to happen until mid-June. |
Enabled. 60 minute time limitation per job. Also pull and push hooks are in here. Please use something like https://github.com/nextcloud/server/blob/master/.drone.yml#L672 to avoid running pushes to PRs with a branch in the same repo twice ;) |
I'm afraid the acceptance tests in Nextcloud make too many assumptions about running from source. They will not work against the snap (or indeed any package). |
I've written a few very simple acceptance tests that would have caught the blocking issue, but unfortunately Drone won't run snaps either. Circle CI will though-- would someone with power mind enabling that for me? |
Argh, but Circle CI won't BUILD them! It's still trusty, just with a xenial kernel. How frustrating. |
Ah ha-- Circle CI DOES work. I just have to build in docker, then run outside of docker. So yeah, @MorrisJobke do you think you could enable that? |
Should be enabled now: https://circleci.com/gh/nextcloud/nextcloud-snap |
The dependency seems to have been addressed. Any change of a v12 snap? |
@sempervictus I think that is worth it to wait till they do a proper release: Instead of just taking a snapshot of the stable12 branch. |
@pachulo I am not tracking ya there: v12 was released in May, the same day this issue was raised. If that isn't what ya meant, could you clarify? |
hey @maiki ! Yeah, I will try to clarify: nextcloud 12.0.0 was released in May but included this bug. The fix is now already merged in master and stable12 branches of nextcloud, but they still haven't released a version with the fix included (that will be version 12.0.1): Once they release it, the snap will be updated (if no other flaws affect it). |
Another issue caused by updating to v12: nextcloud/server#5532. |
@kyrofa , btw, just upgaded to 12/edge channel and my theming has disappeared. I've tried to changed background and logo once again - it didn't help. Probably it is related to this new issue. |
Finally the upstream 12.0.1 has been released! |
I've opened a PR to see how this version behaves. |
And did you try to upgrade manually? Is it still saying something about redis? |
|
still in Maintenance mode.... |
how can I rollback? |
Huh, no idea what's happening there. Disabling maintenance mode doesn't seem to actually do it, eh? Yeah, to get back up and running try |
Well, rollback succeeded. |
Back to 11.0.5snap2 |
I'll try an upgrade a bit later as well, see if I can duplicate. |
Let me know how i can Help.... |
Tried an upgrade just now, it went without any problems. I just received my Nextcloud Box last month, so I didn't have time to fiddle with anything other than enabling SSH. Running the Snap (or more precisely the entire Nextcloud Box image) on a RaspberryPi 3B. |
@shadowempire123 and @kyrofa, please troubleshoot in a different place next time. This ticket is tracking the snap update status, not for troubleshooting specific upgrade errors; a new issue or the forums would be a better place to discuss. Thanks. |
@maiki um. @shadowempire123 was helping test out the snap update. Could that have been done on the PR? Yes, but I requested testing here as well, and got feedback here. I'm not going to tell someone "please test the fix for this issue, but let's go talk about it in the forums." I'm just thankful that people are helping me test it out. |
Thanks @niemalsnever! I appreciate the feedback. I have no idea how the firmware upgrade could have affected this, but you never know. |
@kyrofa I don't think that is a bad idea. Or maybe open another issue and link to this one. I need to track this issue, but I just read a bunch of messages that weren't relevant. If there is a better place for proposals, let me know and I will submit it there. Just trying to cut back on email. 😄 |
Fair enough @maiki, I hear you, and can certainly appreciate the problem! I'll try to encourage fix testing discussions to happen on the PR. |
just a last update from my side: Thx for your support. |
How odd! Well, I'm glad it worked on the second try, we'll see if anyone else has similar issues. Thanks for taking another run at it! |
The fix for this issue has been merged. Once builds have completed it will be available in the beta channel. |
Hej, I've done the upgrade from 11.04 to 12.04 without any problems.Met vriendelijke groet, Cordiali saluti, Send from BQ Aquaris X5 PlusOp 5 dec. 2017 8:47 p.m. schreef Kyle Fazzari <[email protected]>:
Now the update went through and I am on 12.0.4.
How odd! Well, I'm glad it worked on the second try, we'll see if anyone else has similar issues. Thanks for taking another run at it!
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
|
The call for testing is out, folks. The more testers the merrier! |
Is there an ETA on when this is gonna be merged into master? |
This should be rolling out to everyone soon, thanks to all the testers! ❤️ |
It's now in stable. If you refreshed to candidate in order to test, feel free to refresh back:
|
@kyrofa Thanks for the heads up, I was planning on asking about that. |
Sure thing. There isn't a problem with anyone staying on candidate, of course. You'll just automatically update when release candidates come out, which tend to be stable. If you want even more stability, get back on stable. More info on the release strategy page (which I need to update a little). |
@kyrofa
The text was updated successfully, but these errors were encountered: