Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: allow proper linebreak in multiselect for narrow mobile screens #712

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

violoncelloCH
Copy link
Contributor

e.g. in Mail app
image
vs
image

@violoncelloCH violoncelloCH added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Nov 7, 2019
@jancborchardt
Copy link
Contributor

Wondering if we should do this, or limit to 1 line and ellipsize. Cause for long names or email addresses or so, they might break to 3 rows or something and then it looks extra weird?

@violoncelloCH
Copy link
Contributor Author

violoncelloCH commented Nov 11, 2019

That's what came to my mind as well while doing this but I wasn't sure what would be better. In the use case of the mail app I want to see which account I'm sending from, however if we ellipse too much this would only display my name (which is probably the same for all accounts) and cut off the end / relevant part of the mail (domain)...
What do you think @jancborchardt ?

@jancborchardt
Copy link
Contributor

Is it possible to limit what is shown inside the multiselect depending on screen width?

Meaning we could show both name and email in the open dropdown, but only the email when directly picked. (This only on mobile of course.)

Cause the "from" info is comparably the least important info on this screen, and thus should not take 2 lines.
Also, on mobile the vertical space is limited, especially when writing which means the keyboard is extended.

@skjnldsv
Copy link
Contributor

What is the status here?

@jancborchardt
Copy link
Contributor

@skjnldsv do you have an idea about the question in my comment? Or @violoncelloCH? :)

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 8, 2020

@skjnldsv do you have an idea about the question in my comment? Or @violoncelloCH? :)

You could maybe implement this with your own multiselect template, but that would be tricky, there is no steps methods to display a text or not. Only solution in my head would be to use media queries for it 🤔

@skjnldsv skjnldsv force-pushed the fix/noissue/muliselect-linebreak-on-mobile branch from 0b6d733 to 28f0f3c Compare March 25, 2020 08:26
@skjnldsv
Copy link
Contributor

Rebased.

@skjnldsv skjnldsv merged commit f6812c3 into master Oct 19, 2020
@skjnldsv skjnldsv deleted the fix/noissue/muliselect-linebreak-on-mobile branch October 19, 2020 17:07
@skjnldsv skjnldsv added the bug Something isn't working label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants