Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcAppSidebar): RTL support #6193

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

[next] fix(NcAppSidebar): RTL support #6193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/components/NcAppSidebar/NcAppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,14 +1267,14 @@ $top-buttons-spacing: 6px;

z-index: 1500;
top: 0;
right: 0;
inset-inline-end: 0;
display: flex;
overflow-x: hidden;
overflow-y: auto;
flex-direction: column;
flex-shrink: 0;
height: 100%;
border-left: 1px solid var(--color-border);
border-inline-start: 1px solid var(--color-border);
background: var(--color-main-background);
// Make close button positioned relative to the header
position: relative;
Expand All @@ -1292,7 +1292,7 @@ $top-buttons-spacing: 6px;
position: absolute;
z-index: 100;
top: $top-buttons-spacing;
right: $top-buttons-spacing;
inset-inline-end: $top-buttons-spacing;
width: var(--default-clickable-area);
height: var(--default-clickable-area);
opacity: $opacity_normal;
Expand All @@ -1319,14 +1319,14 @@ $top-buttons-spacing: 6px;
flex: 0 0 auto;
}
.app-sidebar-header__desc {
padding-left: 0;
padding-inline-start: 0;
flex: 1 1 auto;
min-width: 0;
padding-right: calc(2 * var(--default-clickable-area) + $top-buttons-spacing);
padding-top: $desc-vertical-padding-compact;

&.app-sidebar-header__desc--without-actions {
padding-right: calc(var(--default-clickable-area) + $top-buttons-spacing);
padding-inline-end: calc(var(--default-clickable-area) + $top-buttons-spacing);
}

.app-sidebar-header__tertiary-actions {
Expand All @@ -1338,7 +1338,7 @@ $top-buttons-spacing: 6px;
}
.app-sidebar-header__menu {
top: $top-buttons-spacing;
right: calc(var(--default-clickable-area) + $top-buttons-spacing); // left of the close button
inset-inline-end: calc(var(--default-clickable-area) + $top-buttons-spacing); // left of the close button
position: absolute;
}
}
Expand All @@ -1358,7 +1358,7 @@ $top-buttons-spacing: 6px;
padding-right: calc(2 * var(--default-clickable-area) + $top-buttons-spacing);

&.app-sidebar-header__desc--without-actions {
padding-right: calc(var(--default-clickable-area) + $top-buttons-spacing);
padding-inline-end: calc(var(--default-clickable-area) + $top-buttons-spacing);
}
}
}
Expand Down Expand Up @@ -1394,7 +1394,7 @@ $top-buttons-spacing: 6px;

// custom overrides
&--with-tertiary-action {
padding-left: 6px;
padding-inline-start: 6px;
}

&--editable .app-sidebar-header__mainname-form,
Expand Down Expand Up @@ -1468,7 +1468,7 @@ $top-buttons-spacing: 6px;

// main menu
.app-sidebar-header__menu {
margin-left: 5px;
margin-inline-start: 5px;
}
}

Expand Down Expand Up @@ -1515,7 +1515,7 @@ $top-buttons-spacing: 6px;
.slide-right-leave-active,
.slide-right-enter-active {
transition-duration: var(--animation-quick);
transition-property: margin-right;
transition-property: margin-inline-end;
}

.slide-right-enter-to,
Expand All @@ -1525,7 +1525,7 @@ $top-buttons-spacing: 6px;

.slide-right-enter-from,
.slide-right-leave-to {
margin-right: calc(-1 * var(--app-sidebar-width));
margin-inline-end: calc(-1 * var(--app-sidebar-width));
}
</style>

Expand Down