Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSidebar): RTL support #6187

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(NcAppSidebar): RTL support #6187

merged 1 commit into from
Nov 5, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Nov 4, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Nov 4, 2024
@hamza221 hamza221 self-assigned this Nov 4, 2024
@hamza221
Copy link
Contributor Author

hamza221 commented Nov 4, 2024

/backport to next

@Antreesy Antreesy mentioned this pull request Nov 4, 2024
Merged
Antreesy
Antreesy reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in Talk, if right is not defined with another stylesheet
check also for padding-right and padding-left in this file
image

GretaD
GretaD approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second reviewer, so this doesnt get blocked

@hamza221
Copy link
Contributor Author

hamza221 commented Nov 5, 2024

Looks fine in Talk, if right is not defined with another stylesheet check also for padding-right and padding-left in this file image

I was not able to test all the classes on Calendar

@Antreesy
Copy link
Contributor

Antreesy commented Nov 5, 2024 •
edited
Loading

In Files:

  • actions
  • border
  • animation
image

I was checking missing elements, let me push

@hamza221 @Antreesy
fix(NcAppSidebar): RTL support
ba66cc6 
Signed-off-by: Hamza Mahjoubi <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
Antreesy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
image

@hamza221 hamza221 merged commit e2128f0 into master Nov 5, 2024
19 checks passed
@hamza221 hamza221 deleted the fix/rtl/NcAppSidebar branch November 5, 2024 17:04
@backportbot backportbot bot mentioned this pull request Nov 5, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@GretaD GretaD GretaD approved these changes

@susnux susnux susnux approved these changes

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] Close button to the left
4 participants
@hamza221 @Antreesy @susnux @GretaD