Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] [NcRichText] Add style to mount point for custom picker and custom widget elements #6140

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 11, 2024

Backport of PR #6108

…and custom wiget because mounting in vue3 does not replace the mount point but sets its innerHTML

Signed-off-by: Julien Veyssier <[email protected]>
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews technical debt feature: richtext Related to the richtext component labels Oct 11, 2024
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes still seem appropriate but I'm not sure all of NcRichText works with Vue 3.

@juliusknorr juliusknorr merged commit aa10544 into next Oct 11, 2024
20 checks passed
@juliusknorr juliusknorr deleted the backport/6108/next branch October 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants