Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAppNavigationItem): make collapsible by clicking on whole component #6131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GVodyanov
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

No graphical changes

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Oct 4, 2024
@GVodyanov GVodyanov self-assigned this Oct 4, 2024
GVodyanov and others added 3 commits October 7, 2024 17:28
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
@GVodyanov GVodyanov requested a review from susnux October 7, 2024 15:30
// If no links are defined, and collapsing is enabled, we want it to collapse
if (this.to === null && this.href === null && this.collapsible === true) {
this.toggleCollapse()
event.preventDefault()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux Sorry for the late reply, but it is needed because there are multiple actions that clicking an AppNavigationItem could trigger. If a link is defined, you go to the link, if not and the component is collapsible, it would collapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only the arrow of the "Hidden calendars" element unfolds it
2 participants