-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcEmojiPicker): adjust hover effects to new design #6056
Conversation
Signed-off-by: Antreesy <[email protected]>
I am not sure but was there not a design review call where it was said that round outline makes sense for emoji? (Changes look good, just want to make sure this is what designer intended) |
I'd keep it rounded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really do not care, both are fine. Noticed that e.g. messengers like Telegram also have "angular" hover effect.
Changes are clean 👍
(To cite a user I asked: "IPhone users would prefer the round one, Android users the angular one.")
/backport to next |
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade