Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSettingsSection): remove default h2 margin-top #5897

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 2, 2024

☑️ Resolves

  • NcSettingsSection header has unneeded top margin from global styles
  • NcSettingsSection should only has its own padding around the content

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: settings Related to the settings component labels Aug 2, 2024
@ShGKme ShGKme added this to the 8.15.2 milestone Aug 2, 2024
@ShGKme ShGKme self-assigned this Aug 2, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 2, 2024

/backport to next

@ShGKme ShGKme force-pushed the fix/NcSettingsSection--remove-header-top-margin branch from dc45b82 to 1698d82 Compare August 2, 2024 09:41
@susnux susnux merged commit 8092e7a into master Aug 2, 2024
19 checks passed
@susnux susnux deleted the fix/NcSettingsSection--remove-header-top-margin branch August 2, 2024 21:28
@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: settings Related to the settings component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants