Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): adjust elements styles to unit-less line-height #5889

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(style): adjust elements styles to unit-less line-height #5889

merged 1 commit into from
Aug 1, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 1, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 2. developing Work in progress feature: input-field Covering the InputField, TextField, ... feature: list-item Related to the list-item component labels Aug 1, 2024
@ShGKme ShGKme added this to the 8.15.2 milestone Aug 1, 2024
@ShGKme ShGKme mentioned this pull request Aug 1, 2024
Draft
@Antreesy @ShGKme
style: adjust elements styles to unit-less line-height
932ef9d 
Signed-off-by: Maksim Sukharev <[email protected]>
Co-authored-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the fix/line-height-in-calculations branch from 88175cc to 932ef9d Compare August 1, 2024 12:19
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 1, 2024

Rebased onto master

@ShGKme ShGKme marked this pull request as ready for review August 1, 2024 12:19
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 1, 2024
susnux
susnux approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that there is lh 👍

@susnux susnux merged commit 5fbed93 into master Aug 1, 2024
20 checks passed
@susnux susnux deleted the fix/line-height-in-calculations branch August 1, 2024 13:27
@susnux
Copy link
Contributor

susnux commented Aug 1, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Aug 1, 2024
Merged
2 tasks
@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@susnux susnux susnux approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ... feature: list-item Related to the list-item component
Projects
None yet
Milestone
8.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @susnux @marcoambrosini @Antreesy