fix(NcAppSidebar): manage focus only after transition has finished #5833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
When NcAppSidebar appears, two things happen:
Moving focus scrolls container (
NcContent
) to the sidebar which is out of the container (in the process of moving from the right side). It results in weird animation when the margin changes the width + scroll of the container instead of the position of the sidebar.P.S.
overflow: hidden
only hides the scrollbar and content, but the container is still scrollable.overflow: clip
is used to actually remove scrolling.Slowed animation 1000 times to see the effect: sidebar moves left and right by 1 pixel.
🖼️ Screenshots
🚧 Tasks
Alternative solution
Use
overflow: clip
onNcContent
to remove scrolling.🏁 Checklist
next
requested with a Vue 3 upgrade