Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcDialog): Ensure the dialog is correctly labelled by its name #5778

Merged
merged 4 commits into from
Jul 9, 2024
Merged

[next] fix(NcDialog): Ensure the dialog is correctly labelled by its name #5778

merged 4 commits into from
Jul 9, 2024

Commits on Jul 7, 2024

  1. fix(NcDialog): Ensure the dialog is correctly labelled by its name 

    * Added `labelId` prop to NcModal to allow label modal without a name
* Pass the navigation id (the ID of the headline element of NcDialog) to `labelId`
* Added cypress tests

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    bc4d27d View commit details
    Browse the repository at this point in the history

  2. fix(NcAppSettingsDialog): Make sure sections are correctly labelled 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    58347e0 View commit details
    Browse the repository at this point in the history

  3. fix(NcButton): Properly export Typescript types 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    4ba63e1 View commit details
    Browse the repository at this point in the history

  4. fix(NcDialog): Properly export Typescript types 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    9141727 View commit details
    Browse the repository at this point in the history