Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate NcCollectionList component from nextcloud-vue-collections #5757

Merged
merged 2 commits into from
Jul 3, 2024
Merged

feat: migrate NcCollectionList component from nextcloud-vue-collections #5757

merged 2 commits into from
Jul 3, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 2, 2024

☑️ Resolves

  • Move component from nextcloud-vue-collections to @nextcloud/vue library
  • Refactor code:
    • migrate service from Class to simple functions
    • migrate store to composable
    • make NcCollectionListItem a visual component
    • update avatar styles
    • use RouterLink for relative paths in the same app
    • update message.pot translations
    • add docs

🖼️ Screenshots

image

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews component Component discussion and/or suggestion labels Jul 2, 2024
@Antreesy Antreesy added this to the 8.14.0 milestone Jul 2, 2024
@Antreesy Antreesy self-assigned this Jul 2, 2024
@Antreesy Antreesy force-pushed the feat/noid/migrate-vue-collections branch from 0d0f8f9 to eff6808 Compare July 2, 2024 15:45
@susnux susnux requested a review from juliusknorr July 3, 2024 10:11
@Antreesy @susnux
feat(NcCollectionList): merge nextcloud-vue-collections into nextclou…
0637422 
…d/vue

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy @susnux
refactor(NcCollectionList): refactor code
94177fe 
- migrate service from Class to simple functions
- migrate store to composable
- make NcCollectionListItem a visual component
- update avatar styles
- use RouterLink for relative paths in the same app
- update message.pot translations
- add docs

Signed-off-by: Maksim Sukharev <[email protected]>
@susnux susnux force-pushed the feat/noid/migrate-vue-collections branch from eff6808 to 94177fe Compare July 3, 2024 19:46
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 3, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 3, 2024

/backport to next

@Antreesy Antreesy merged commit a671ba4 into master Jul 3, 2024
19 checks passed
@Antreesy Antreesy deleted the feat/noid/migrate-vue-collections branch July 3, 2024 20:45
@backportbot backportbot bot mentioned this pull request Jul 3, 2024
Merged
@susnux susnux mentioned this pull request Jul 4, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Antreesy Antreesy

Labels
4. to release Ready to be released and/or waiting for tests to finish component Component discussion and/or suggestion enhancement New feature or request
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @DorraJaouad