[next] fix(NcRichText): crash on router links rendering #5672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
To test:
nextcloud-vue
- removerm -rf node_modules/vue-router
from nextcloud-vue repo (or usenpm pack
instead ofnpm link
)🖼️ Screenshots
🚧 Tasks
vue-router
fromdevDeps
todeps
to externalize it. Otherwise it is built in and we have 2 routers. We should take router from package users, not during the build.Fixes:
vue
from peer to deps (no changes, just make it correct)Fixes:
🏁 Checklist
next
requested with a Vue 3 upgrade