-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppNavigationItem): Fix popper boundary element #5632
fix(NcAppNavigationItem): Fix popper boundary element #5632
Conversation
I end up in the same scenario as you. I can reproduce the issue on main, then i link and the issue is gone. I do npm ci, kill the link and same as you i cannot reproduce it anymore. |
Let's do this. It sets the element more reliably. I don't see a downside. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense because on mounted the parent should exist which is the content.
And the computed was wrong in the first place, it was never recalculated because document is not reactive
/backport to next |
Signed-off-by: Christoph Wurst <[email protected]>
43034e8
to
a30de5b
Compare
☑️ Resolves
The query selector in the computed prop ran too early, before the element existed. There is no reactivity. Now the boundary element is set very late at mount, when the boundary element does exist in the DOM.
There are a few edge cases, but the menu positions better than before when the boundary fell back to the
body
.🖼️ Screenshots
🚧 Tasks
🏁 Checklist
next
requested with a Vue 3 upgrade