Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidebar): propagate keydown unless mobile #5451

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(sidebar): propagate keydown unless mobile #5451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/NcAppSidebar/NcAppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ A working alternative would be using an icon together with an `aria-label`:
ref="sidebar"
class="app-sidebar"
:aria-labelledby="`app-sidebar-vue-${uid}__header`"
@keydown.esc.stop="isMobile && closeSidebar()">
@keydown.esc="onKeydownEsc">
<header :class="{
'app-sidebar-header--with-figure': hasFigure,
'app-sidebar-header--compact': compact,
Expand Down Expand Up @@ -794,6 +794,18 @@ export default {
}
},

/**
* Close the sidebar on pressing the escape key on mobile
*
* @param {KeyboardEvent} event key down event
*/
onKeydownEsc(event) {
if (this.isMobile) {
event.stopPropagation()
this.closeSidebar()
}
},

onBeforeEnter(element) {
/**
* The sidebar is opening and the transition is in progress
Expand Down
Loading