fix(NcBreadcrumbs): Only render existing hidden breadcrumbs #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Pytal
added
bug
susnux
approved these changes
Mar 26, 2024
emoral435
approved these changes
Mar 27, 2024
|
/backport to next |
This comment was marked as resolved.
This comment was marked as resolved.
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fix [Bug]: when using search to navigate into Files, the location path is not changing nextcloud/server#44005
When some breadcrumbs are hidden and the user tries to navigate to a breadcrumb that comes before the hidden one the component attempts to render a no longer existing crumb so we filter out the indices are no longer present before rendering
🏁 Checklist
nextrequested with a Vue 3 upgrade