Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcRichText*): listen to correct events form NcSelect #5239

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[next] fix(NcRichText*): listen to correct events form NcSelect #5239

merged 2 commits into from
Feb 19, 2024

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

@raimund-schluessler raimund-schluessler changed the base branch from master to next February 11, 2024 10:01
@raimund-schluessler raimund-schluessler changed the title Fix/5232/select event rich text fix(NcRichText*): listen to correct events form NcSelect Feb 11, 2024
@raimund-schluessler raimund-schluessler added this to the 9.0.0-alpha.2 milestone Feb 11, 2024
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Feb 11, 2024
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 11, 2024 10:05
Antreesy
Antreesy approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reference: should follow-up these migration changes: 61bb1f9

Seems legit, but didn't test it. Do you have a guide to reproduce it?

@ShGKme ShGKme changed the title fix(NcRichText*): listen to correct events form NcSelect [next] fix(NcRichText*): listen to correct events form NcSelect Feb 19, 2024
@raimund-schluessler raimund-schluessler merged commit d5b36b6 into next Feb 19, 2024
17 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/5232/select-event-rich-text branch February 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: richtext Related to the richtext component
Projects
None yet
Milestone
9.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

[next] NcRichText* listens to wrong event of NcSelect
3 participants
@raimund-schluessler @ShGKme @Antreesy