Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): width regression fixed #5129

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

emoral435
Copy link
Contributor

☑️ For #5101

🖼️ Screenshots

🏡 After

image

🚧 Tasks

  • The mentioned PR above introduced a regression: the button width became 44px due to NcButton, being width: 44px !important. This pr fixes this!

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@emoral435 emoral435 added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 24, 2024
@emoral435 emoral435 added this to the 8.5.1 milestone Jan 24, 2024
@emoral435 emoral435 self-assigned this Jan 24, 2024
@emoral435 emoral435 force-pushed the fix/a11y/42959/regression-for-width branch from 71050a6 to 743fa02 Compare January 25, 2024 13:18
@emoral435 emoral435 requested a review from Pytal January 25, 2024 13:19
@emoral435
Copy link
Contributor Author

@Pytal Fixed!

@susnux susnux merged commit 20577bc into master Jan 25, 2024
15 checks passed
@susnux susnux deleted the fix/a11y/42959/regression-for-width branch January 25, 2024 18:09
@ShGKme
Copy link
Contributor

ShGKme commented Jan 25, 2024

It is a little bit broken on mobile, where the button is supposed top be 44x50, not 50x50

image

@emoral435
Copy link
Contributor Author

Regression fix in #5149

@susnux susnux mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants