Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcButton): use a as tag for router-link #5091

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(NcButton): use a as tag for router-link #5091

merged 1 commit into from
Jan 18, 2024

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 18, 2024 •
edited
Loading

☑️ Resolves

@raimund-schluessler raimund-schluessler mentioned this pull request Jan 18, 2024
Closed
@raimund-schluessler raimund-schluessler added this to the 8.5.0 milestone Jan 18, 2024
@raimund-schluessler raimund-schluessler added bug Something isn't working 2. developing Work in progress regression Regression of a previous working feature feature: breadcrumbs Related to the breadcrumbs components feature: button labels Jan 18, 2024
@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 18, 2024 18:00
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 18, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jan 18, 2024

Thanks!

emoral435
emoral435 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue / regression that I (sorry) ade, so it looks good to me :) nice catch!

@raimund-schluessler
Copy link
Contributor Author

Fixes the issue / regression that I (sorry) ade, so it looks good to me :) nice catch!

Don't worry, I had a good share in creating the problem 😆 🙈 And we found it before a release, so no harm was done anyway.

@raimund-schluessler raimund-schluessler merged commit 183e127 into master Jan 18, 2024
15 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/5089/button-link branch January 18, 2024 22:14
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components feature: button regression Regression of a previous working feature
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

NcBreadcrumb does not render <a> anymore when to is provided
3 participants
@raimund-schluessler @ShGKme @emoral435