Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcCheckboxContent): correctly check default slot #5058

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

  • Fixes the detection whether NcCheckboxContent has text. Before, it would always be true leading to a wrong padding right.

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component vue 3 Related to the vue 3 migration labels Jan 11, 2024
ShGKme

This comment was marked as resolved.

@raimund-schluessler
Copy link
Contributor Author

Isn't it fixable on NcCheckboxRadioSwitch's side same as in some other component? To avoid tripple rendering.

<template v-if="!!$slots.default" #default>
  <slot />
</template>

Yes, of course. Thanks for remembering that! Fixed it.

@skjnldsv skjnldsv merged commit 6043fd7 into next Jan 12, 2024
14 checks passed
@skjnldsv skjnldsv deleted the fix/noid/checkbox-default-slot branch January 12, 2024 09:00
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants