Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NcActionButtonGroup): replace computed of constant with constant #5023

Merged
merged 1 commit into from
Jan 3, 2024
Merged

refactor(NcActionButtonGroup): replace computed of constant with constant #5023

merged 1 commit into from
Jan 3, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 3, 2024

☑️ Resolves

  • Fixes ESLint warning (methods/computed order)
  • Replace computed with constant in setup to avoid creating unneeded reactive effect

🖼️ Screenshots

No visual changes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added 3. to review Waiting for reviews feature: actions Related to the actions components labels Jan 3, 2024
@ShGKme ShGKme self-assigned this Jan 3, 2024
@Pytal Pytal merged commit 2f0f4c4 into master Jan 3, 2024
15 checks passed
@Pytal Pytal deleted the refactor/NcActionButtonGroup--replace-computed-with-constant branch January 3, 2024 23:37
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews feature: actions Related to the actions components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @raimund-schluessler @Pytal