Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat!: rename checked prop to modelValue #4994

Merged
merged 1 commit into from
Dec 26, 2023
Merged

[next] feat!: rename checked prop to modelValue #4994

merged 1 commit into from
Dec 26, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Dec 25, 2023 •
edited
Loading

☑️ Resolves

  • This PR makes use of the v-model capabilities new to vue 3. The checked prop of NcActionCheckbox, NcActionRadio and NcCheckboxRadioSwitch was renamed to modelValue so the component can be used easier by simply providing v-model="isChecked" instead of v-model:checked="isChecked".

Companion PR to #4990.

@raimund-schluessler raimund-schluessler changed the base branch from master to next December 25, 2023 09:30
@raimund-schluessler raimund-schluessler changed the title Feat/noid/model value [next] feat: rename checked prop to modelValue Dec 25, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Dec 25, 2023
@raimund-schluessler raimund-schluessler changed the title [next] feat: rename checked prop to modelValue [next] feat: rename checked prop to modelValue Dec 26, 2023
@raimund-schluessler raimund-schluessler added feature: checkbox-radio-switch Related to the checkbox-radio-switch component enhancement New feature or request feature: actions Related to the actions components vue 3 Related to the vue 3 migration labels Dec 26, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review December 26, 2023 06:58
@raimund-schluessler raimund-schluessler added the 3. to review Waiting for reviews label Dec 26, 2023
@susnux susnux changed the title [next] feat: rename checked prop to modelValue [next] feat!: rename checked prop to modelValue Dec 26, 2023
susnux
susnux approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the comments about the kebab case but otherwise fine!

@raimund-schluessler
feat: rename checked prop to modelValue
8dc7876 
Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler
Copy link
Contributor Author

Agree with the comments about the kebab case but otherwise fine!

I fixed the kebab case issue. I should've known, since we use it like this every where else.

@raimund-schluessler raimund-schluessler merged commit 8916a34 into next Dec 26, 2023
14 checks passed
@raimund-schluessler raimund-schluessler deleted the feat/noid/model-value branch December 26, 2023 21:19
@raimund-schluessler raimund-schluessler mentioned this pull request Dec 28, 2023
Merged
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
@kyteinsky kyteinsky mentioned this pull request Mar 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components feature: checkbox-radio-switch Related to the checkbox-radio-switch component vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@raimund-schluessler @susnux @skjnldsv @ShGKme