Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): make autocomplete accessible #4904

Merged
merged 5 commits into from
Feb 5, 2024
Merged

fix(NcRichContenteditable): make autocomplete accessible #4904

merged 5 commits into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. refactor(NcRichContenteditable): create 1 tribute for all autocompletes 

    - Fixes `Tribute was already bound to DIV` warning
- Tribute is supposed to be only once on the element
- Simplifies further work with Tribute

Signed-off-by: Grigorii K. Shartsev <[email protected]>
    @ShGKme
    ShGKme committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0bf2293 View commit details
    Browse the repository at this point in the history

  2. refactor(NcRichContenteditable): move constants out of reactive data 

    - `smilesList` is always a constant and reused across all the instances
- tribute options are used only once to initialize tribute

Signed-off-by: Grigorii K. Shartsev <[email protected]>
    @ShGKme
    ShGKme committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    466d368 View commit details
    Browse the repository at this point in the history

  3. refactor(NcRichContenteditable): cancel autoComplete on close 

    - Correctly implement `debounced` method, so that debouncedFunction properties are available and each component instance has its own debounce
- Clear debounce on autoComplete close

Signed-off-by: Grigorii K. Shartsev <[email protected]>
    @ShGKme
    ShGKme committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    81cc8e8 View commit details
    Browse the repository at this point in the history

  4. fix(NcRichContenteditable): make autocomplete accessible 

    Signed-off-by: Grigorii K. Shartsev <[email protected]>
    @ShGKme
    ShGKme committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6e8120b View commit details
    Browse the repository at this point in the history

  5. fix(NcRichContenteditable): provide focus-visible class 

    Signed-off-by: Grigorii K. Shartsev <[email protected]>
    @ShGKme
    ShGKme committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    66034a3 View commit details
    Browse the repository at this point in the history