Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcActions): find actions deeper nested #4804

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Nov 12, 2023

☑️ Resolves

  • This fixes an issue that occured when actions are nested deeper than one level. This can happen e.g. when one puts a loop in a slot, as it happens in NcDashboardWidgetItem, i.e.:
<NcActions>
	<slot name="actions">
		<NcActionButton v-for="action in actions">
			{{ action.text }}
		</NcActionButton>
	</slot>
</NcActions>

These actions were nested two levels deep in two Fragments and were not found with the old logic, causing the action menu to be empty. I changed the logic to be recursive now, finding all actions.

As this occurred in NcDashboardWidgetItem, it is included here as well.

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components feature: dashboard Related to the dashboard widget vue 3 Related to the vue 3 migration labels Nov 12, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Nov 12, 2023
@raimund-schluessler raimund-schluessler changed the title fix(NcActions): find actions deeper nested [next] fix(NcActions): find actions deeper nested Nov 12, 2023
@raimund-schluessler
Copy link
Contributor Author

Could we get this reviewed?

@raimund-schluessler
Copy link
Contributor Author

@susnux Would you have time to review this PR, maybe?

@raimund-schluessler
Copy link
Contributor Author

Fixed the conflict. @susnux Mind reviewing this as well, please?

@susnux susnux merged commit 04947cc into next Nov 28, 2023
14 checks passed
@susnux susnux deleted the fix/noid/nested-actions branch November 28, 2023 20:13
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components feature: dashboard Related to the dashboard widget vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants