Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat(NcModal): migrate to vue 3 #4722

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[next] feat(NcModal): migrate to vue 3 #4722

merged 1 commit into from
Oct 31, 2023

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

  • This migrates NcModal to vue 3.

@raimund-schluessler
feat(NcModal): migrate to vue 3
ffb11ff 
Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: modal Related to the modal component vue 3 Related to the vue 3 migration labels Oct 31, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Oct 31, 2023
@susnux susnux merged commit ff400ec into next Oct 31, 2023
15 checks passed
@susnux susnux deleted the feat/2154/modal branch October 31, 2023 10:46
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: modal Related to the modal component vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @susnux @ShGKme