Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDialog): NcModal registration #4682

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(NcDialog): NcModal registration #4682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/NcDialog/NcDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@

export default defineComponent({
name: 'NcDialog',

components: {
NcModal,
Copy link
Contributor

@susnux susnux Oct 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NcModal,
NcDialogButton,
NcModal,

},

props: {
/** Name of the dialog (the heading) */
name: {
Expand Down Expand Up @@ -174,7 +179,7 @@
/**
* Size of the underlying NcModal
* @default 'small'
* @values 'small', 'normal', 'large', 'full'

Check warning on line 182 in src/components/NcDialog/NcDialog.vue

View workflow job for this annotation

GitHub Actions / eslint 

Invalid JSDoc tag name "values"
*/
size: {
type: String,
Expand Down Expand Up @@ -334,7 +339,6 @@

return {
NcDialogButton,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NcDialogButton,

NcModal,

handleButtonClose,
handleClosing,
Expand Down
Loading