Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigationItem): Ensure primary styling when the item is active #4650

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(NcAppNavigationItem): Ensure primary styling when the item is active #4650

merged 1 commit into from
Oct 16, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 15, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
NcAppNavigationItem-primary-on-active-route image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Oct 15, 2023
ShGKme
ShGKme approved these changes Oct 15, 2023
View reviewed changes
cypress/visual/AppNavigationItem.cy.ts Outdated Show resolved Hide resolved
cypress/visual/AppNavigationItem.cy.ts Outdated Show resolved Hide resolved
@susnux susnux force-pushed the fix/nc-app-navigation-item-active-menu branch 2 times, most recently from 86afeaf to dfb624c Compare October 15, 2023 17:43
@susnux susnux force-pushed the fix/nc-app-navigation-item-active-menu branch from dfb624c to 4f83461 Compare October 15, 2023 17:51
@raimund-schluessler raimund-schluessler merged commit 0016c06 into master Oct 16, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/nc-app-navigation-item-active-menu branch October 16, 2023 07:25
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NcAppNavigationItem: wrong color of action menu "three dots" for active item
3 participants
@susnux @raimund-schluessler @ShGKme