Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NcBreadcrumbs styles to wrap buttons #4640

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix NcBreadcrumbs styles to wrap buttons #4640

merged 1 commit into from
Oct 19, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Oct 12, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Before After
image Screenshot from 2023-10-18 16-15-54

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 12, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Oct 12, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Oct 12, 2023
Closed
szaimen
szaimen requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it doesnt seem to work correctly yet...
(the button gets pushed down but the file list does not get pushed down so they overlap...
image

skjnldsv
skjnldsv requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. The big white space is the issue. :)
If really small width, we can just hide the share icon too in server.

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2023
Merged
4 tasks
@JuliaKirschenheuter
Copy link
Contributor Author

Thank you @skjnldsv for your help!
I think i've done steps you have mentioned, but for me it is still not working ;(

Screenshot from 2023-10-17 12-30-34

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft October 17, 2023 10:30
@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 17, 2023
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review October 18, 2023 14:16
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft October 18, 2023 14:37
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review October 18, 2023 15:01
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 18, 2023
@JuliaKirschenheuter
Fix NcBreadcrumbs styles to wrap buttons
d77e806 
Signed-off-by: julia.kirschenheuter <[email protected]>
szaimen
szaimen approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv skjnldsv merged commit d939939 into master Oct 19, 2023
15 checks passed
@skjnldsv skjnldsv deleted the fix/36965-fix-breadcrumbs_styles branch October 19, 2023 09:00
@Pytal Pytal added the bug Something isn't working label Oct 23, 2023
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaKirschenheuter @skjnldsv @szaimen @Pytal