Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): run eslint on migrated files #4630

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(eslint): run eslint on migrated files #4630

merged 1 commit into from
Oct 9, 2023

Conversation

raimund-schluessler
Copy link
Contributor

We forgot to run eslint on the already migrated files. This PR enables it, and fixes the eslint problems.

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews vue 3 Related to the vue 3 migration labels Oct 9, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Oct 9, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review October 9, 2023 15:24
@susnux susnux merged commit 5f1c330 into next Oct 9, 2023
15 checks passed
@susnux susnux deleted the fix/noid/eslint branch October 9, 2023 23:13
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @susnux @ShGKme