Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invert datepicker buttons on dark mode #4618

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: invert datepicker buttons on dark mode #4618

merged 1 commit into from
Oct 9, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Oct 7, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-10-07 at 17-33-37 Aufgaben - Nextcloud image
Screenshot 2023-10-07 at 17-31-40 Aufgaben - Nextcloud image

@raimund-schluessler raimund-schluessler added bug Something isn't working 2. developing Work in progress feature: datepicker Related to the date/time picker component design Design, UX, interface and interaction design labels Oct 7, 2023
@raimund-schluessler raimund-schluessler added this to the 7.12.7 milestone Oct 7, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 7, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review October 7, 2023 15:42
ShGKme
ShGKme approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks fine by code, thanks!

@raimund-schluessler raimund-schluessler merged commit d075ba9 into master Oct 9, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/4617/datepicker-darkmode branch October 9, 2023 05:13
@raimund-schluessler raimund-schluessler mentioned this pull request Oct 11, 2023
Merged
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
7.12.7
Development

Successfully merging this pull request may close these issues.

dark mode: date picker forward | backward buttons lack contrast
3 participants
@raimund-schluessler @ShGKme @marcoambrosini