chore(vue3): Migrate NcColorPicker #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
raimund-schluessler
added
2. developing
raimund-schluessler
requested review from
susnux,
skjnldsv,
Pytal and
ShGKme
raimund-schluessler
added
3. to review
raimund-schluessler
force-pushed
the
chore/2154/color-picker
branch
from
6cd7968
to
fdd821d
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
chore/2154/color-picker
branch
from
fdd821d
to
dd82a61
Compare
ShGKme
requested changes
Oct 2, 2023
Signed-off-by: Raimund Schlüßler <[email protected]>
ShGKme
approved these changes
Oct 2, 2023
susnux
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrate
NcColorPickerto vue3.Unfortunately, the previously used library
vue-colordoes not support vue3 yet (see xiaokaike/vue-color#225), so I had to switch to a fork.Please note, the button in the second example in the docs does currently not work due to #4564.Edit: Advaced mode seems to have an issue still.Works now.