chore(vue3): Nc*Field rename default to icon slot #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
feat/2152/input-field-icon-slot
branch
2 times, most recently
from
d1bfb9b
to
bf36543
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
added
2. developing
raimund-schluessler
added
3. to review
skjnldsv
approved these changes
Sep 19, 2023
ShGKme
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ShGKme What do you think of this approach:
We rename the
defaultslot ofNcInputFieldtoiconand then simply use!!$slots.iconas you proposed. This way, one anyway has to wrap the content for theiconslot in atemplatetag and it is easier to explain that one has to usev-ifon thetemplatewhen toggling the existence of an icon.This then makes everything reactive without the need for an overkill solution, no?
And I think renaming to
iconanyway makes sense, since it makes it clearer that it's, well, for an icon.