fix: handling of empty values in NcDateTimePickerNative #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
st3iny
force-pushed
the
fix/empty-datetime-picker-native
branch
from
ec6d1bc
to
141c9e4
Compare
st3iny
added
3. to review
|
Is this ready for review? |
st3iny
force-pushed
the
fix/empty-datetime-picker-native
branch
from
141c9e4
to
49803ee
Compare
st3iny
force-pushed
the
fix/empty-datetime-picker-native
branch
from
49803ee
to
314c156
Compare
|
Is there a before after or some reproduction steps how to check if it actually works? |
st3iny
force-pushed
the
fix/empty-datetime-picker-native
branch
from
314c156
to
e8d5ec3
Compare
The style guide now renders the currently selected value. Have a look at: It should render a date if one is selected and null otherwise. |
7 tasks
szaimen
reviewed
Oct 4, 2023
src/components/NcDateTimePickerNative/NcDateTimePickerNative.vue
Outdated
Show resolved
Hide resolved
ShGKme
approved these changes
Oct 4, 2023
JuliaKirschenheuter
approved these changes
Oct 5, 2023
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/empty-datetime-picker-native
branch
from
e8d5ec3
to
05d58f6
Compare
st3iny
added
4. to release
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The native date time picker doesn't handle empty values gracefully. Currently, there will be errors in the console due to a failing type check.
The style guide now renders the currently selected value. Have a look at it on the preview:
https://deploy-preview-4540--nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepickernative
Links are apparently broken. You may need to scroll to the NcDateTimePickerNative manually.
It should render a date if one is selected and null otherwise.
🖼️ Screenshots
🚧 Tasks
🏁 Checklist