Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align NcCheckboxRadioSwitch labels #4490

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

raimund-schluessler
Copy link
Contributor

🏚️ Before 🏡 After
Screenshot 2023-08-31 at 09-26-48 Nextcloud Vue Style Guide Screenshot 2023-08-31 at 09-27-20 Nextcloud Vue Style Guide

I did not align the label of NcCheckboxRadioSwitch type="switch", because it has a wider icon and aligning it does not really work well.

Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Aug 31, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Aug 31, 2023
@raimund-schluessler raimund-schluessler added the design Design, UX, interface and interaction design label Aug 31, 2023
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 31, 2023 07:33
@skjnldsv skjnldsv merged commit 69959c3 into master Aug 31, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/noid/align-checkbox-labels branch August 31, 2023 08:28
@Pytal Pytal mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants