Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix visibility of default counterbubble #4154

Merged
merged 1 commit into from
May 25, 2023
Merged

fix visibility of default counterbubble #4154

merged 1 commit into from
May 25, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 25, 2023

When choosing e.g. black as primary color in dark mode:

Before After
image image

@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels May 25, 2023
@szaimen szaimen enabled auto-merge May 25, 2023 10:31
@szaimen szaimen merged commit d72f769 into master May 25, 2023
@szaimen szaimen deleted the enh/noid/fix-nccounter-visiblity branch May 25, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @jancborchardt @marcoambrosini