Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of nav contents #4135

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

pulsejet
Copy link
Contributor

@pulsejet pulsejet commented May 17, 2023

Padding was only applicable to the list, but should apply to the footer too.

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
footer-before footer_after

@pulsejet pulsejet added bug Something isn't working 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. design Design, UX, interface and interaction design labels May 17, 2023
@pulsejet pulsejet added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 17, 2023
@pulsejet
Copy link
Contributor Author

pulsejet commented May 17, 2023

This doesn't play nice with scrollbars
EDIT: good now.

@pulsejet pulsejet added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 17, 2023
@pulsejet
Copy link
Contributor Author

What's the general policy on merging after approval? Is it okay to merge to master after 2 approvals or wait for the maintainer to do it?

@raimund-schluessler raimund-schluessler merged commit 7e14037 into master May 23, 2023
@raimund-schluessler raimund-schluessler deleted the pulsejet/nav-align branch May 23, 2023 08:34
@raimund-schluessler
Copy link
Contributor

/backport to stable7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants