Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit event when NcAppContent list pane is resized #4071

Merged
merged 1 commit into from
May 10, 2023

Conversation

julien-nc
Copy link
Contributor

The upper context sometimes needs to know when the list pane is resized. If, for example, the content of the NcAppContent's default slot needs to be re-rendered or needs to adjust its layout/size.

Concrete use case: GpxPod displays a Maplibre map that:

  • reacts if the window is resized 🎉
  • does not react if its container size changes 😞 We need to explicitly tell the map component to resize when this happens.

Suggestion: Emit resize:list in NcAppContent when Splitpanes (the 'list' slot) is resized by the user.
What do you think?

@julien-nc julien-nc added enhancement New feature or request 3. to review Waiting for reviews feature: app-content Related to the app-content component labels May 9, 2023
@julien-nc julien-nc added this to the 7.11.4 milestone May 9, 2023
@julien-nc julien-nc changed the title Emit event when NcAppContent list slot is resized Emit event when NcAppContent list pane is resized May 9, 2023
@skjnldsv skjnldsv modified the milestones: 7.11.4, 8.0.0 May 10, 2023
@raimund-schluessler raimund-schluessler merged commit 78c07ef into master May 10, 2023
@raimund-schluessler raimund-schluessler deleted the enh/noid/event-resize-appcontent-list branch May 10, 2023 07:36
@nickvergessen nickvergessen mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-content Related to the app-content component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants