Fix native open in a new tab in components with a custom router link #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/noid/open-in-a-new-tab-in-custom-router-link
branch
from
d3bd67c
to
5c7756c
Compare
ShGKme
added
3. to review
ShGKme
requested review from
raimund-schluessler,
nickvergessen,
Chartman123 and
skjnldsv
skjnldsv
approved these changes
Apr 6, 2023
Chartman123
approved these changes
Apr 6, 2023
ShGKme
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
Ctrl+Click,Shift+Clickand etc. on a link inNcListItemandNcAppNavigationitemopens the link in a new tab.Actual behavior
Nothing happened
Problem description
In
NcListItemandNcAppNavigationitemwhen the item is aRouterLink, navigation after a click is handled manually, while default behavior stops withevent.preventDefault().It breaks a native web-browser behavior - the ability to open a link in a new tab by combining a Click with a modifier key, for example,
Ctrl+Click.This PR checks if modifiers are pressed before the manual navigation and preventing default behavior.
Regression of: #3775
Continue of: #3922
Related: nextcloud/talk-desktop#104