enh(NcDatetimePicker): convert lang computed value to prop #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to overwrite the locale configuration of the upstream date picker library. Some apps (e.g. Calendar) overwrite some of the default values which are specified here. Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
enhancement
st3iny
requested review from
raimund-schluessler,
JuliaKirschenheuter,
skjnldsv and
Pytal
st3iny
added a commit
to nextcloud/calendar
that referenced
this pull request
Mar 29, 2023
This is just a workaround. Real fix at nextcloud-libraries/nextcloud-vue#3941 Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added a commit
to nextcloud/calendar
that referenced
this pull request
Mar 29, 2023
This is just a workaround. Real fix at nextcloud-libraries/nextcloud-vue#3941 Signed-off-by: Richard Steinmetz <[email protected]>
|
Why can't this be fixed here instead of in calendar then? |
Now, this would be ideal but is not possible atm. The problem is about the This is the reason I need to propagate custom locale/language settings based on the user's locale. |
JuliaKirschenheuter
approved these changes
Mar 30, 2023
st3iny
added a commit
to nextcloud/calendar
that referenced
this pull request
Mar 30, 2023
This is just a workaround. Real fix at nextcloud-libraries/nextcloud-vue#3941 Signed-off-by: Richard Steinmetz <[email protected]>
backportbot-nextcloud bot
pushed a commit
to nextcloud/calendar
that referenced
this pull request
Mar 30, 2023
This is just a workaround. Real fix at nextcloud-libraries/nextcloud-vue#3941 Signed-off-by: Richard Steinmetz <[email protected]>
backportbot-nextcloud bot
pushed a commit
to nextcloud/calendar
that referenced
this pull request
Mar 30, 2023
This is just a workaround. Real fix at nextcloud-libraries/nextcloud-vue#3941 Signed-off-by: Richard Steinmetz <[email protected]>
Pytal
approved these changes
Mar 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for nextcloud/calendar#4259
This allows to overwrite the locale configuration of the upstream date picker library. Some apps (e.g. Calendar) overwrite some of the default values which are specified here.
https://github.com/nextcloud/calendar/blob/90f4f29204a95a49daa3961e33addf80f5720e7e/src/components/Shared/DatePicker.vue#L24