-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NcRichText style #3932
Fix NcRichText style #3932
Conversation
Signed-off-by: Julien Veyssier <[email protected]>
I think that should be fine. |
I think the class should still be there pulled in from https://github.com/nextcloud/nextcloud-vue/blob/fix/noid/ncrichtext-style/src/components/NcRichText/autolink.js#L69
Seems quite odd, nothing I'd be aware of, but might be that another app had the style imported and now that isn't the case anymore? |
Just importing would be fine I think as well |
Signed-off-by: Julien Veyssier <[email protected]>
I think I found the issue about the class. I implemented a basic fix which does not override the class of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes missing underlining for links to github etc.
But links to 127.0.0.1 are still not clickable :(
@juliushaertl Just wanna make sure you agree with this change 😁. Are there potentially other specific cases (other components) for which the class should not be overridden? |
@juliushaertl We missed something when moving
RichText
in here asNcRichText
.The
richtext.scss
file is not used anymore. It had to be imported separately whenRichText
was used.We could now simply import it in
NcRichText
.@raimund-schluessler No problem with importing it, right?
Another problem raised in nextcloud/spreed#9163 is that links have the
rich-text--component
class and they apparently used to have therich-text--external-link
(withuseMarkdown
set to false). This leads to them not being underlined anymore.@juliushaertl Apparently this appeared after
@nextcloud/vue-richtext
v2.0.4. Does it ring a bell? Any intentional change in the link class?Fix nextcloud/spreed#9163