Use component with :is #3774
Merged
Use component with :is #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
feature: breadcrumbs
raimund-schluessler
requested review from
marcoambrosini,
susnux,
Pytal and
skjnldsv
ShGKme
reviewed
Feb 17, 2023
There was a problem hiding this comment.
I really like this refactoring. Regardless of Vue 3 migration, using the dynamic component seems to be much more explicit, especially when :is is bound not directly but by v-bind="object". At the same time, the purpose of the is special attribute is combability with templates in HTML documents, which is not the case.
However, this approach is used not only in these two components but in many others in a bit less straight way.
What about refactoring all of them?
Binding is via v-bind="object"
NcListItem
NcAppNavigationItem
NcUserBubble
Direct using is on a component
NcUserBubble
raimund-schluessler
force-pushed
the
fix/noid/component-element
branch
from
93c87c1
to
5ea9caa
Compare
Done. |
raimund-schluessler
force-pushed
the
fix/noid/component-element
branch
from
5ea9caa
to
9bf8ce9
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/component-element
branch
from
9bf8ce9
to
2813e64
Compare
susnux
approved these changes
Feb 17, 2023
Pytal
approved these changes
Feb 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue3 limits the use of the custom elements
:isspecial attribute to the reserved<component>tag only, see https://v3-migration.vuejs.org/breaking-changes/custom-elements-interop.html#customized-built-in-elementsVue2 does not care. So we migrate already to keep #3692 simpler.