Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): export more components to main package #3729

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented Feb 6, 2023

Required for nextcloud/server#36383

@skjnldsv @Pytal Can you share some light on why two components were not exported for the main package bundle in https://github.com/nextcloud/nextcloud-vue/blob/ed6f3ed2f82bb3a25246708fef3f8a5c6188103c/src/components/index.js#L62-L68 ?

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Feb 6, 2023
@raimund-schluessler
Copy link
Contributor

The timezone picker isn't exported by accident, I would say.

The NcInputField is deliberately not exported, since it is an internal component used by NcPasswordField and NcTextField. As per the NcInputField docs:
https://github.com/nextcloud/nextcloud-vue/blob/27d09d66f582cedccdcb34223368d70daab06904/src/components/NcInputField/NcInputField.vue#L25-L29

@juliusknorr
Copy link
Contributor Author

The NcInputField is deliberately not exported, since it is an internal component used by NcPasswordField and NcTextField. As per the NcInputField docs:

Ok, thanks. Then we'll need to migrate the usage in server of that one.

@Pytal
Copy link
Contributor

Pytal commented Feb 6, 2023

@skjnldsv @Pytal Can you share some light on why two components were not exported for the main package bundle in

NcEllipsisedOption was originally only used by NcMultiselect but was also needed for the NcSelect* components so it was hoisted from the NcMultiselect folder in ed6f3ed#diff-f341f5a900ec8175943fcefd443dda0e5bd2dde34062b5461674f0d40b133175, if useful for developers then we can go ahead and export it as well

@raimund-schluessler
Copy link
Contributor

The NcInputField is deliberately not exported, since it is an internal component used by NcPasswordField and NcTextField. As per the NcInputField docs:

Ok, thanks. Then we'll need to migrate the usage in server of that one.

I guess that's to discuss with @skjnldsv.

@juliusknorr
Copy link
Contributor Author

Changed the comment a bit to be more clear about why this should not be used now.

@raimund-schluessler raimund-schluessler merged commit 9a82660 into master Feb 13, 2023
@raimund-schluessler raimund-schluessler deleted the enh/more-exports branch February 13, 2023 13:26
@Pytal Pytal mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants