Add aria-labels to colorpicker buttons #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/3679/colorpicker-buttons
branch
2 times, most recently
from
0d5d95d
to
0fae9f9
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/3679/colorpicker-buttons
branch
from
0fae9f9
to
e4b181c
Compare
raimund-schluessler
added
bug
raimund-schluessler
requested review from
JuliaKirschenheuter,
GretaD,
skjnldsv,
Pytal and
artonge
skjnldsv
reviewed
Jan 26, 2023
Pytal
approved these changes
Jan 26, 2023
skjnldsv
approved these changes
Jan 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the missing text / aria-labels warnings from the NcColorpicker.