-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NcIconSvgWrapper to public API #3630
Conversation
Signed-off-by: Christopher Ng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muuuch cleaner! Thank you Chris! 🚀
There are two followups while we're at it:
|
That would be nice 👍 |
You and me both lol |
Unnecessary SVG title element addition is dropped as screenreaders will read the
aria-label
onspan
so we also reduce system resource usage