Fix focus returning to top of page instead of actions toggle button #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
Pytal
requested review from
raimund-schluessler,
JuliaKirschenheuter,
skjnldsv and
marcoambrosini
4 tasks
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/a11y-actions-focus
branch
from
858f52b
to
db25ef8
Compare
skjnldsv
approved these changes
Dec 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix focused element when tabbing after reaching the last actions menu item
Before
https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactions-1 (Scroll down to "Multiple actions")
Focus returns to the top of the page
After
https://deploy-preview-3530--nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactions-1 (Scroll down to "Multiple actions")
Focus returns to the actions menu toggle button