Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better readability of long file and event names #3295

Closed
wants to merge 1 commit into from
Closed

Better readability of long file and event names #3295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/NcAppSidebar/NcAppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,11 @@ $top-buttons-spacing: 6px;
overflow: hidden;
width: 100%;
margin: 0;
white-space: nowrap;
white-space: normal;
text-overflow: ellipsis;
display: -webkit-box;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also add the non webkit variant

Copy link
Member Author

@Jerome-Herbinet Jerome-Herbinet Sep 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @juliushaertl, I did some research this morning, and it seems that there are no specific tags for non-webkit browsers.
"display: -webkit-box" has no equivalent and seems to be compatible with all current browsers, except maybe Opera Mini and Internet Explorer (which is no longer maintained ... thank god). Moreover, the Firefox development tool does not know "display: -moz-box" for example and there is no "display: box" (for exemple as well). Also, "-webkit-line-clamp" and "-webkit-box-orient" seem to have no equivalent either and are, against all current appearances, compatible with the vast majority of current browsers. No CSS error in the Firefox inspector tool. All the research I've done on information on this subject, dating back less than a year, all leads to this set of properties, whether it's discussions, forums, blog posts, docs, etc:

display: -webkit-box;
text-overflow: ellipsis;
-webkit-line-clamp: 3;
-webkit-box-orient: vertical;
overflow: hidden;

What I say is not gospel, but I think these properties are worth trying (the risk of a problem seems very low if there is one). What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this property is weird and unfortunately there is no non-webkit options.
Firefox supports it though https://caniuse.com/?search=webkit-box

-webkit-line-clamp: 3;
-webkit-box-orient: vertical;
}

// subtitle
Expand Down